feat(review): flag handles in the review player (metadata only)
Deploy / deploy (push) Successful in 3m31s
Deploy / deploy (push) Successful in 3m31s
Renders run 8 frames past the cut at each end. Directors were flagging glitches in unfixed handles as shot problems, so the player now marks them — without trimming or burning anything into the EXRs/MOV/MP4. - Version.handleHead/handleTail/pictureStartFrame, Export.handleHead/ handleTail; migration backfills pipeline exports and their preview versions from the manifest's handleFrames (else 8) - AE panel: "Includes handles [8] frames each end" -> manifest.review; older manifests fall back to source.handleFrames - finalize copies handles onto the Version; worker 1.6.4 reports the head slate length (pictureStartSeconds), else the player infers it as MP4 frames - EXR frameCount - Player: hatched HANDLE / SLATE regions and cut marks on the timeline, "HEAD/TAIL HANDLE · NOT IN EDIT" overlay on handle frames, HANDLE badge on notes, "Edit range only" toggle (default on in the client portal) - Staff Handles editor on the review page for manual uploads/corrections Also fixes two player bugs found while testing: timeToFrame floored float error (every seek landed a frame early), and J/reverse never ran (the keyboard effect's cleanup stopped it on the next render). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -45,6 +45,8 @@ var PANEL_VERSION = "2.6.2";
|
||||
pipelineStatusText: null,
|
||||
urgentCheckbox: null,
|
||||
skipPreviewCheckbox: null,
|
||||
handlesCheckbox: null,
|
||||
handleFramesField: null,
|
||||
submissionNoteField: null,
|
||||
qcList: null,
|
||||
qcNotesField: null,
|
||||
@@ -3476,6 +3478,9 @@ var PANEL_VERSION = "2.6.2";
|
||||
CONFIG.bannerImagePath = trimText(fBanner.text);
|
||||
CONFIG.artistEmail = trimText(fEmail.text);
|
||||
CONFIG.handleFrames = parseInt(fHandles.text, 10) || 8;
|
||||
if (uiState.handleFramesField) {
|
||||
uiState.handleFramesField.text = String(CONFIG.handleFrames);
|
||||
}
|
||||
CONFIG.pathMappings = trimText(fMappings.text);
|
||||
CONFIG.sequenceStart = parseInt(fSeqStart.text, 10) || 1001;
|
||||
saveConfig();
|
||||
@@ -4196,7 +4201,23 @@ var PANEL_VERSION = "2.6.2";
|
||||
return manifest;
|
||||
}
|
||||
|
||||
// Handles the render carries past the cut. Review metadata only: the web
|
||||
// player marks these frames as "not in edit". Nothing in the comp or the
|
||||
// render changes — unticked just means the frames are all in the edit.
|
||||
function reviewHandles() {
|
||||
var frames;
|
||||
if (!uiState.handlesCheckbox || !uiState.handlesCheckbox.value) {
|
||||
return { handleHead: 0, handleTail: 0 };
|
||||
}
|
||||
frames = parseInt(uiState.handleFramesField ? uiState.handleFramesField.text : "", 10);
|
||||
if (isNaN(frames) || frames < 0) {
|
||||
frames = CONFIG.handleFrames;
|
||||
}
|
||||
return { handleHead: frames, handleTail: frames };
|
||||
}
|
||||
|
||||
function submitExport(manifest, urgent, force) {
|
||||
manifest.review = reviewHandles();
|
||||
var body = {
|
||||
manifest: manifest,
|
||||
force: force ? true : false
|
||||
@@ -4803,6 +4824,25 @@ var PANEL_VERSION = "2.6.2";
|
||||
"un-punched-in EXRs — where a preview rebuilt from these frames\n" +
|
||||
"would be the wrong picture.";
|
||||
|
||||
var handlesGroup = pipelinePanel.add("group");
|
||||
handlesGroup.orientation = "row";
|
||||
handlesGroup.alignChildren = ["left", "center"];
|
||||
handlesGroup.spacing = 6;
|
||||
uiState.handlesCheckbox = handlesGroup.add("checkbox", undefined, "Includes handles");
|
||||
uiState.handlesCheckbox.value = true;
|
||||
uiState.handleFramesField = handlesGroup.add("edittext", undefined, String(CONFIG.handleFrames));
|
||||
uiState.handleFramesField.characters = 3;
|
||||
handlesGroup.add("statictext", undefined, "frames each end");
|
||||
uiState.handlesCheckbox.helpTip =
|
||||
"The render runs past the cut at both ends (handles). The review\n" +
|
||||
"player marks those frames HANDLE / NOT IN EDIT so a glitch in a\n" +
|
||||
"handle isn't mistaken for a problem in the shot.\n\n" +
|
||||
"Review-only: nothing is burned in and the EXRs are unchanged.\n" +
|
||||
"Untick for a render cut exactly to the edit.";
|
||||
uiState.handlesCheckbox.onClick = function () {
|
||||
uiState.handleFramesField.enabled = uiState.handlesCheckbox.value;
|
||||
};
|
||||
|
||||
var slateNoteGroup = pipelinePanel.add("group");
|
||||
slateNoteGroup.orientation = "row";
|
||||
slateNoteGroup.alignChildren = ["fill", "top"];
|
||||
|
||||
Reference in New Issue
Block a user