feat(review): flag handles in the review player (metadata only)
Deploy / deploy (push) Successful in 3m31s

Renders run 8 frames past the cut at each end. Directors were flagging
glitches in unfixed handles as shot problems, so the player now marks
them — without trimming or burning anything into the EXRs/MOV/MP4.

- Version.handleHead/handleTail/pictureStartFrame, Export.handleHead/
  handleTail; migration backfills pipeline exports and their preview
  versions from the manifest's handleFrames (else 8)
- AE panel: "Includes handles [8] frames each end" -> manifest.review;
  older manifests fall back to source.handleFrames
- finalize copies handles onto the Version; worker 1.6.4 reports the
  head slate length (pictureStartSeconds), else the player infers it
  as MP4 frames - EXR frameCount
- Player: hatched HANDLE / SLATE regions and cut marks on the timeline,
  "HEAD/TAIL HANDLE · NOT IN EDIT" overlay on handle frames, HANDLE badge
  on notes, "Edit range only" toggle (default on in the client portal)
- Staff Handles editor on the review page for manual uploads/corrections

Also fixes two player bugs found while testing: timeToFrame floored
float error (every seek landed a frame early), and J/reverse never ran
(the keyboard effect's cleanup stopped it on the next render).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
twotalesanimation
2026-09-22 15:07:29 +02:00
parent 2817c7e815
commit 2e9fa45580
27 changed files with 938 additions and 23 deletions
@@ -28,6 +28,7 @@ import { submitApproval } from "@/actions/approvals";
import { internallyApproveShot } from "@/actions/shots";
import { useToast } from "@/components/ui/use-toast";
import { ShareWithClientButton } from "@/components/versions/ShareWithClientButton";
import { VersionHandlesButton } from "@/components/versions/VersionHandlesButton";
import {
CheckCircle2,
XCircle,
@@ -50,6 +51,9 @@ interface ReviewPageClientProps {
fps: number;
duration: number | null;
frameCount: number | null;
handleHead: number | null;
handleTail: number | null;
pictureStartFrame: number | null;
approvalStatus: string;
notes: string | null;
isClientVisible: boolean;
@@ -283,6 +287,20 @@ export function ReviewPageClient({
</DropdownMenu>
</div>
{/* Handles — outside the breadcrumb so it never gets squeezed */}
{userRole !== "CLIENT" && (
<div className="shrink-0">
<VersionHandlesButton
key={version.id}
versionId={version.id}
handleHead={version.handleHead}
handleTail={version.handleTail}
pictureStartFrame={version.pictureStartFrame}
onSaved={() => router.refresh()}
/>
</div>
)}
{/* Approval status */}
<span
className={cn(
@@ -361,6 +379,7 @@ export function ReviewPageClient({
versionId={version.id}
onAddComment={handleAddComment}
onAnnotationSaved={handleAnnotationSaved}
handles={version}
/>
</div>