feat(pipeline): automate picture-lock trimming in the preview build
Deploy / deploy (push) Successful in 10m37s
Deploy / deploy (push) Successful in 10m37s
Previews used to ship the full padded (handle-included) render to clients, with an artist manually pulling picture lock and hand-trimming the comp to match. The automated preview stage now trims the client comp to the picture-lock edit itself (a fixed handle count off each end, per the studio's existing convention) and separately builds an ungraded, full-duration picture-lock reference MP4 as a diagnostic sidecar to check back against. A new "No Picture Lock" panel checkbox is the single override for shots where picture lock is missing or wrong, falling back to today's untrimmed behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -32,6 +32,18 @@ export interface PreviewManifest {
|
||||
mp4Output: string;
|
||||
slateScopeProp: string;
|
||||
slateSubmissionProp: string;
|
||||
/** Skip picture-lock trimming and the reference render entirely (§9, picture lock). */
|
||||
noPictureLock: boolean;
|
||||
/** `{footageRoot}/{showId}/_PICLOCKS`, mirroring the panel's getShowFootageRoot(). */
|
||||
piclockDir: string;
|
||||
/** e.g. "UNG_106" — mirrors the panel's getEpisodePrefix(); the picture-lock glob prefix. */
|
||||
piclockGlobPrefix: string;
|
||||
seqTimecodeStart: string | null;
|
||||
seqTimecodeEnd: string | null;
|
||||
/** Studio-standard head/tail handle count, applied symmetrically. */
|
||||
handleFrames: number;
|
||||
/** Full-duration (handles included), ungraded picture-lock reference render. */
|
||||
piclockRefOutput: string;
|
||||
slate: {
|
||||
versionName: string;
|
||||
date: string;
|
||||
@@ -58,6 +70,7 @@ type ExportForPreview = {
|
||||
fps: number;
|
||||
vfxScope: string | null;
|
||||
submissionNote: string | null;
|
||||
noPictureLock: boolean;
|
||||
};
|
||||
|
||||
/**
|
||||
@@ -78,18 +91,27 @@ export async function buildPreviewManifest(exportRow: ExportForPreview): Promise
|
||||
description: true,
|
||||
notes: true,
|
||||
slateDescription: true,
|
||||
seqTimecodeStart: true,
|
||||
seqTimecodeEnd: true,
|
||||
project: { select: { name: true, code: true, showId: true, pipelineConfig: true } },
|
||||
},
|
||||
});
|
||||
if (!shot) throw new PipelineError(404, "Shot not found for export");
|
||||
|
||||
const cfg = await getPreviewConfig();
|
||||
const [cfg, handleFrames] = await Promise.all([getPreviewConfig(), getConfigNumber("validation.handleFrames")]);
|
||||
// Per-production templates: each show has its own slate/overlay AEP, and
|
||||
// above all its own show LUT. Falling back to another show's would render a
|
||||
// preview that is quietly the wrong colour.
|
||||
const templates = await resolveProjectTemplates(shot.project);
|
||||
const base = `${shot.shotCode}_cmp_TT_${exportRow.versionString}`;
|
||||
|
||||
// Same convention as the panel's getShowFootageRoot()/getEpisodePrefix(): the
|
||||
// picture-lock plate lives at {footageRoot}/{showId}/_PICLOCKS, glob-matched
|
||||
// by "{showId}[_{episode}]_*".
|
||||
const showId = shot.project.showId?.trim() || shot.project.code;
|
||||
const piclockDir = templates.footageRoot ? `${templates.footageRoot}/${showId}/_PICLOCKS` : "";
|
||||
const piclockGlobPrefix = shot.episode?.trim() ? `${showId}_${shot.episode.trim()}` : showId;
|
||||
|
||||
return {
|
||||
stage: "PREVIEW",
|
||||
exportId: exportRow.id,
|
||||
@@ -110,6 +132,13 @@ export async function buildPreviewManifest(exportRow: ExportForPreview): Promise
|
||||
mp4Output: `${exportRow.outputDir}/${base}.mp4`,
|
||||
slateScopeProp: cfg.slateScopeProp,
|
||||
slateSubmissionProp: cfg.slateSubmissionProp,
|
||||
noPictureLock: exportRow.noPictureLock,
|
||||
piclockDir,
|
||||
piclockGlobPrefix,
|
||||
seqTimecodeStart: shot.seqTimecodeStart,
|
||||
seqTimecodeEnd: shot.seqTimecodeEnd,
|
||||
handleFrames,
|
||||
piclockRefOutput: `${exportRow.outputDir}/${base}_PICLOCK_REF.mp4`,
|
||||
slate: {
|
||||
versionName: base,
|
||||
date: slateDate(),
|
||||
@@ -158,6 +187,7 @@ export async function inheritPreviewMedia(
|
||||
deliveryMovPath: true,
|
||||
previewMovKey: true,
|
||||
thumbnailKey: true,
|
||||
piclockRefKey: true,
|
||||
versionId: true,
|
||||
},
|
||||
});
|
||||
@@ -174,6 +204,7 @@ export async function inheritPreviewMedia(
|
||||
deliveryMovPath: donor.deliveryMovPath,
|
||||
previewMovKey: donor.previewMovKey,
|
||||
thumbnailKey: donor.thumbnailKey,
|
||||
piclockRefKey: donor.piclockRefKey,
|
||||
// The Version row stays attached to the export that actually produced the
|
||||
// media; this one only points at the same files.
|
||||
versionId: donor.versionId,
|
||||
@@ -267,6 +298,8 @@ export interface FinalizeInput {
|
||||
thumbnailKey?: string;
|
||||
metadataKey?: string;
|
||||
logFileKey?: string;
|
||||
/** Full-duration, ungraded picture-lock reference MP4 — a diagnostic sidecar, not a Version. */
|
||||
piclockRefKey?: string;
|
||||
};
|
||||
renderStats?: { renderSeconds?: number; previewSeconds?: number };
|
||||
media?: { width?: number; height?: number; frameCount?: number; fps?: number; fileName?: string };
|
||||
@@ -446,6 +479,7 @@ export async function finalizePreview(jobId: string, machineId: string, body: Fi
|
||||
...(artifacts.previewMovKey ? { previewMovKey: artifacts.previewMovKey } : {}),
|
||||
...(artifacts.thumbnailKey ? { thumbnailKey: artifacts.thumbnailKey } : {}),
|
||||
...(artifacts.metadataKey ? { metadataKey: artifacts.metadataKey } : {}),
|
||||
...(artifacts.piclockRefKey ? { piclockRefKey: artifacts.piclockRefKey } : {}),
|
||||
}
|
||||
);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user