fix(validation): anchor the timecode check on a delivered plate
Deploy / deploy (push) Successful in 6m12s

UNG_110_030_010 v002 failed with a 461614-frame offset on a render whose
timecode was correct. Two causes, both in how the plate reference was
recorded.

The comp held three same-length elements and the timing plate was picked
by duration alone, so a PRERENDER won on layer order. Using a pre-render
as the timecode reference is circular anyway: it was rendered from this
comp, so it can only ever agree with it — including when both are wrong.
Only footage under the Footage Root is now eligible; among those, longest
still wins.

The offset itself came from the plate's frameStart. AE writes renders as
"..._PRERENDER_01001.exr" while delivered plates use "....01001.exr", and
the parser only handled the dot form, so the number fell back to the
comp's frame range — 462615 against a render numbered from 1001. Both
separators now parse, and an unparseable name omits the field rather than
filling it with a number from the wrong coordinate system.

Verified against the real manifest: the BG01 plate is now chosen over
both pre-renders, and all three filenames parse to 1001.

Panel 2.2.1, worker 1.2.1.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
twotalesanimation
2026-08-14 08:56:18 +02:00
parent 1163bd6455
commit 991abe072c
5 changed files with 65 additions and 17 deletions
+44 -13
View File
@@ -32,7 +32,7 @@ var SETTINGS_KEY = "cfg";
// Bump on every change deployed to a workstation. The panel reports this to
// the server on load, so Pipeline → Machines shows which version each machine
// is actually running and flags the ones left behind.
var PANEL_VERSION = "2.2.0";
var PANEL_VERSION = "2.2.1";
(function VFXReviewConnector(thisObj) {
var uiState = {
@@ -3701,9 +3701,32 @@ var PANEL_VERSION = "2.2.0";
return plates;
}
// The element the comp's timing came from: longest duration, first on tie —
// the same rule buildShotFromCode uses to pick primaryFootage.
// The element the comp's timing came from.
//
// Delivered plates win over anything else in the comp: a shot routinely
// contains pre-renders and CG passes of exactly the same length, and using
// one of those as the timecode reference is circular — it was rendered from
// this comp, so it can only ever agree with it, including when both are
// wrong. Only footage living under the configured Footage Root is camera
// material. Among equals, longest duration wins, as buildShotFromCode does
// when it picks primaryFootage.
function pickTimingPlate(plates) {
var root = normalizeSlashes(trimText(CONFIG.footageRoot)).toLowerCase();
var delivered = [];
var i;
if (root) {
for (i = 0; i < plates.length; i += 1) {
if (normalizeSlashes(plates[i].path).toLowerCase().indexOf(root) === 0) {
delivered.push(plates[i]);
}
}
}
return pickLongest(delivered.length ? delivered : plates);
}
function pickLongest(plates) {
var best = null;
var i;
@@ -3712,23 +3735,30 @@ var PANEL_VERSION = "2.2.0";
best = plates[i];
}
}
return best;
}
function toManifestPlate(plate, frameStart) {
function toManifestPlate(plate) {
var ref = { element: plate.element, path: plate.path };
var parsed = parseFrameNumberFromPath(plate.path);
var start = parsed !== null ? parsed : frameStart;
ref.frameStart = start;
ref.frameEnd = start + Math.max(0, plate.frames - 1);
// Only ever the plate's *own* file numbering. When the name carries no
// frame number the field is left out entirely rather than filled with
// the comp's frame range — those are different coordinate systems, and
// a wrong number here silently skews the timecode comparison by the
// difference between them.
if (parsed !== null) {
ref.frameStart = parsed;
ref.frameEnd = parsed + Math.max(0, plate.frames - 1);
}
return ref;
}
// "UNG_102_019_010_BG01_TT_v001.01001.exr" -> 1001
// "..._BG01_TT_v001.01001.exr" -> 1001, and "..._PRERENDER_01001.exr" -> 1001:
// renders written by AE separate the frame number with an underscore rather
// than a dot, and both turn up as layers in a shot comp.
function parseFrameNumberFromPath(path) {
var match = String(path).match(/\.(\d{2,9})\.[A-Za-z0-9]+$/);
var match = String(path).match(/[._](\d{2,9})\.[A-Za-z0-9]+$/);
if (!match) {
return null;
@@ -3791,12 +3821,12 @@ var PANEL_VERSION = "2.2.0";
timingPlate = pickTimingPlate(plates);
if (timingPlate) {
manifest.source = {
timingPlate: toManifestPlate(timingPlate, frameStart),
timingPlate: toManifestPlate(timingPlate),
plates: [],
handleFrames: CONFIG.handleFrames
};
for (i = 0; i < plates.length; i += 1) {
manifest.source.plates.push(toManifestPlate(plates[i], frameStart));
manifest.source.plates.push(toManifestPlate(plates[i]));
}
// Only claim a start source when this session actually resolved one
// for this shot — an AEP opened from disk has no such history, and a
@@ -3805,7 +3835,8 @@ var PANEL_VERSION = "2.2.0";
manifest.source.startSource = buildState.lastStartSource;
manifest.source.startFrames = buildState.lastStartFrames;
}
diagLog("manifest plates: " + plates.length + ", timing plate " + timingPlate.element);
diagLog("manifest plates: " + plates.length + ", timing plate " +
timingPlate.element + " (" + timingPlate.path + ")");
} else {
diagLog("no file-backed footage found in " + comp.name +
" — the render's timecode cannot be checked against a plate");