revert(pipeline): back out picture-lock trimming from the preview build
Deploy / deploy (push) Successful in 6m19s
Deploy / deploy (push) Successful in 6m19s
Production fallout after enabling it: the trimmed EXR footage started
after the head handle as intended, but the overlay's burn-in timecode
(hardcoded to start at frame 1001) did not shift with it, so the
delivered burn-in no longer matched the footage. The picture-lock
reference render also never worked correctly in practice. Reverts the
AE panel checkbox, the preview-build script's trim/reference logic, and
the server/worker plumbing around it back to their pre-feature state
(82dfaee) — untrimmed previews, no picture-lock reference, overlay
timecode correct again.
The noPictureLock/piclockRefKey schema columns and their migration are
deliberately left in place: they're already applied in production, and
dropping an applied migration's file risks the next `prisma migrate
deploy`. They sit unused and harmless until this is revisited.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -438,19 +438,6 @@ public sealed class JobExecutor
|
||||
job.Id, machineId, "thumbnail", result.ThumbnailPath, "image/jpeg", shutdown);
|
||||
}
|
||||
|
||||
// Diagnostic sidecar, not a deliverable — an upload failure here must
|
||||
// never hold back the mov/mp4/thumbnail that already succeeded.
|
||||
string? piclockRefKey = null;
|
||||
if (result.PiclockRefPath is not null)
|
||||
{
|
||||
piclockRefKey = await _api.UploadArtifactAsync(
|
||||
job.Id, machineId, "piclockRef", result.PiclockRefPath, "video/mp4", shutdown);
|
||||
if (piclockRefKey is null)
|
||||
{
|
||||
_log.LogWarning("Picture-lock reference upload failed for job {JobId} (non-fatal)", job.Id);
|
||||
}
|
||||
}
|
||||
|
||||
_spooler.Enqueue("finalize", job.Id, new Dictionary<string, object?>
|
||||
{
|
||||
["machineId"] = machineId,
|
||||
@@ -459,9 +446,7 @@ public sealed class JobExecutor
|
||||
["deliveryMovPath"] = manifest.MovOutput,
|
||||
["previewMovKey"] = previewKey,
|
||||
["thumbnailKey"] = thumbKey,
|
||||
["piclockRefKey"] = piclockRefKey,
|
||||
},
|
||||
["piclockSkippedReason"] = result.Build?.PiclockSkippedReason,
|
||||
["renderStats"] = new Dictionary<string, object?>
|
||||
{
|
||||
["previewSeconds"] = (int)result.Seconds,
|
||||
|
||||
Reference in New Issue
Block a user