revert(pipeline): back out picture-lock trimming from the preview build
Deploy / deploy (push) Successful in 6m19s
Deploy / deploy (push) Successful in 6m19s
Production fallout after enabling it: the trimmed EXR footage started
after the head handle as intended, but the overlay's burn-in timecode
(hardcoded to start at frame 1001) did not shift with it, so the
delivered burn-in no longer matched the footage. The picture-lock
reference render also never worked correctly in practice. Reverts the
AE panel checkbox, the preview-build script's trim/reference logic, and
the server/worker plumbing around it back to their pre-feature state
(82dfaee) — untrimmed previews, no picture-lock reference, overlay
timecode correct again.
The noPictureLock/piclockRefKey schema columns and their migration are
deliberately left in place: they're already applied in production, and
dropping an applied migration's file risks the next `prisma migrate
deploy`. They sit unused and harmless until this is revisited.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -3962,9 +3962,6 @@ var PANEL_VERSION = "2.5.0";
|
||||
if (uiState.skipPreviewCheckbox && uiState.skipPreviewCheckbox.value) {
|
||||
body.skipPreview = true;
|
||||
}
|
||||
if (uiState.noPictureLockCheckbox && uiState.noPictureLockCheckbox.value) {
|
||||
body.noPictureLock = true;
|
||||
}
|
||||
|
||||
if (CONFIG.artistEmail) {
|
||||
body.submittedByEmail = CONFIG.artistEmail;
|
||||
@@ -4534,13 +4531,6 @@ var PANEL_VERSION = "2.5.0";
|
||||
"For deliverables framed differently from the review — unscaled or\n" +
|
||||
"un-punched-in EXRs — where a preview rebuilt from these frames\n" +
|
||||
"would be the wrong picture.";
|
||||
uiState.noPictureLockCheckbox = pipelineRow1.add("checkbox", undefined, "No Picture Lock");
|
||||
uiState.noPictureLockCheckbox.helpTip =
|
||||
"Skip picture-lock trimming and the picture-lock reference render\n" +
|
||||
"for this export.\n\n" +
|
||||
"Check if picture lock is missing or wrong for this shot — the\n" +
|
||||
"preview build will fall back to the full rendered range instead\n" +
|
||||
"of trimming against bad data.";
|
||||
|
||||
var slateNoteGroup = pipelinePanel.add("group");
|
||||
slateNoteGroup.orientation = "row";
|
||||
|
||||
Reference in New Issue
Block a user