revert(pipeline): back out picture-lock trimming from the preview build
Deploy / deploy (push) Successful in 6m19s
Deploy / deploy (push) Successful in 6m19s
Production fallout after enabling it: the trimmed EXR footage started
after the head handle as intended, but the overlay's burn-in timecode
(hardcoded to start at frame 1001) did not shift with it, so the
delivered burn-in no longer matched the footage. The picture-lock
reference render also never worked correctly in practice. Reverts the
AE panel checkbox, the preview-build script's trim/reference logic, and
the server/worker plumbing around it back to their pre-feature state
(82dfaee) — untrimmed previews, no picture-lock reference, overlay
timecode correct again.
The noPictureLock/piclockRefKey schema columns and their migration are
deliberately left in place: they're already applied in production, and
dropping an applied migration's file risks the next `prisma migrate
deploy`. They sit unused and harmless until this is revisited.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -20,10 +20,6 @@ export const pipelineConfigSchema = z.object({
|
||||
templateAep: z.string().max(1000).optional().nullable(),
|
||||
/** Where per-shot pre-renders live, imported by Import Renders. */
|
||||
rendersRoot: z.string().max(1000).optional().nullable(),
|
||||
/** Bare footage root (e.g. "V:/_FOOTAGE") the panel's Pull Picture Lock reads
|
||||
* from at `{footageRoot}/{showId}/_PICLOCKS` — same convention as the panel's
|
||||
* own `getShowFootageRoot()`. */
|
||||
footageRoot: z.string().max(1000).optional().nullable(),
|
||||
/** Overrides for templates that depart from the {showId}_* convention. */
|
||||
overlayComp: z.string().max(200).optional().nullable(),
|
||||
previewComp: z.string().max(200).optional().nullable(),
|
||||
@@ -38,7 +34,6 @@ export type PipelineConfigInput = z.infer<typeof pipelineConfigSchema>;
|
||||
export interface ResolvedTemplates {
|
||||
templateAep: string;
|
||||
rendersRoot: string;
|
||||
footageRoot: string;
|
||||
overlayComp: string;
|
||||
previewComp: string;
|
||||
lutComp: string;
|
||||
@@ -83,11 +78,10 @@ export async function resolveProjectTemplates(project: {
|
||||
return fallback;
|
||||
};
|
||||
|
||||
const [defaultAep, defaultMov, defaultMp4, defaultFootageRoot] = await Promise.all([
|
||||
const [defaultAep, defaultMov, defaultMp4] = await Promise.all([
|
||||
getConfigValue("preview.templateAep"),
|
||||
getConfigValue("preview.movTemplate"),
|
||||
getConfigValue("preview.mp4Template"),
|
||||
getConfigValue("preview.footageRoot"),
|
||||
]);
|
||||
|
||||
return {
|
||||
@@ -95,7 +89,6 @@ export async function resolveProjectTemplates(project: {
|
||||
// No sensible studio-wide default: a renders root that points at another
|
||||
// show's folder is worse than an empty one the panel can report.
|
||||
rendersRoot: pick("rendersRoot", ""),
|
||||
footageRoot: pick("footageRoot", defaultFootageRoot),
|
||||
overlayComp: pick("overlayComp", convention.overlayComp),
|
||||
previewComp: pick("previewComp", convention.previewComp),
|
||||
lutComp: pick("lutComp", convention.lutComp),
|
||||
|
||||
Reference in New Issue
Block a user