feat(render-pipeline): validation, QC and delivery builder
Completes RenderPipeline2 phases 3-5. Additive throughout: with validation.enabled=false the pipeline behaves exactly as before. Validation (§8) runs on the worker straight after a render, while it still holds the job and the files are local. Everything is read from the EXR header — one 64 KB read per sampled frame, no pixel decode — so the engine needs no oiiotool. The render job deliberately stays open through the stage, so a worker that dies there is reaped and retried instead of stranding the export in VALIDATING. Timecode is the primary check and is anchored on the plate, never the API: measured on the live show, Shot.timecodeStart is the editorial in-point and sits one handle-length (8f) ahead of the plate, so checking against it would pass the defective exports and fail the correct ones. Reference precedence is manifest timing plate -> plate found on disk -> API value, and the API rank is WARN-only. The panel now resolves plate provenance by walking the comp's own footage layers, so the worker never guesses which element carries the comp's timing. Verified against real studio renders via the new --validate mode: it catches both defect classes seen in shipped work — the +8 handle offset and frame-derived timecode (00:00:41:17 = frame 1001 at 24fps). QC (§10) is one service behind two front doors, API-key for the panel and session for the web. PASS means ready to upload and nothing else; FAIL sets the comp task to CHANGES. The panel gains a QC section that imports the real EXR sequence at full res rather than the H.264. Delivery (§11) rides the existing queue as a DELIVERY_BUILD job: hard links with a copy fallback, verification by re-hashing delivered bytes against the validation-time digest, manifest.json and the CSV report. fsutil hardlink list is unavailable over SMB, so link identity is never queried — reading the bytes back covers links and copies alike. Also fixes ApiClient.ProgressAsync throwing on transport failure, which would have aborted work in flight during a brief server outage; progress reporting is best-effort by contract. Removes the stale RenderWorker/ rule from the root .gitignore. The worker's source is tracked like the rest of the repo and its own .gitignore already covers bin/, obj/ and publish/; the rule silently excluded new files while the existing 20 stayed tracked. Not yet applied: migration 20260813000000 was hand-written because the dev database was unavailable — run prisma migrate deploy and verify before relying on it. None of this has run against a live server. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -66,9 +66,42 @@ interface ExportDetail {
|
||||
note: string | null;
|
||||
createdAt: string;
|
||||
}[];
|
||||
validations: {
|
||||
id: string;
|
||||
renderJobId: string;
|
||||
checkName: string;
|
||||
status: string;
|
||||
expected: string | null;
|
||||
actual: string | null;
|
||||
message: string | null;
|
||||
details: unknown;
|
||||
createdAt: string;
|
||||
}[];
|
||||
qcReviews: {
|
||||
id: string;
|
||||
result: string;
|
||||
notes: string | null;
|
||||
reviewerName: string | null;
|
||||
source: string;
|
||||
createdAt: string;
|
||||
}[];
|
||||
deliveryItems: {
|
||||
id: string;
|
||||
status: string;
|
||||
exrPath: string | null;
|
||||
linkMode: string | null;
|
||||
package: { id: string; name: string; episode: string; status: string; packageNumber: number };
|
||||
}[];
|
||||
};
|
||||
}
|
||||
|
||||
const CHECK_STYLES: Record<string, string> = {
|
||||
PASS: "text-emerald-400",
|
||||
FAIL: "text-red-400",
|
||||
WARN: "text-amber-400",
|
||||
SKIPPED: "text-zinc-500",
|
||||
};
|
||||
|
||||
export function ExportDetailClient({ exportId }: { exportId: string }) {
|
||||
const { toast } = useToast();
|
||||
const queryClient = useQueryClient();
|
||||
@@ -189,6 +222,93 @@ export function ExportDetailClient({ exportId }: { exportId: string }) {
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Validation results — newest run first */}
|
||||
{e.validations.length > 0 && (
|
||||
<div className="rounded-lg border border-zinc-800 bg-zinc-900/40">
|
||||
<div className="px-4 py-2.5 border-b border-zinc-800 text-sm font-medium text-white flex items-center gap-3">
|
||||
Validation
|
||||
{(() => {
|
||||
const latestRun = e.validations[e.validations.length - 1].renderJobId;
|
||||
const rows = e.validations.filter((v) => v.renderJobId === latestRun);
|
||||
const failed = rows.filter((v) => v.status === "FAIL").length;
|
||||
const warned = rows.filter((v) => v.status === "WARN").length;
|
||||
return (
|
||||
<span className={cn("text-xs", failed ? "text-red-400" : warned ? "text-amber-400" : "text-emerald-400")}>
|
||||
{failed ? `${failed} failed` : warned ? `${warned} warning${warned > 1 ? "s" : ""}` : "all checks passed"}
|
||||
</span>
|
||||
);
|
||||
})()}
|
||||
</div>
|
||||
<div className="divide-y divide-zinc-800/60">
|
||||
{(() => {
|
||||
const latestRun = e.validations[e.validations.length - 1].renderJobId;
|
||||
// Failures first: the reason the export stopped should not need scrolling for.
|
||||
const order = { FAIL: 0, WARN: 1, PASS: 2, SKIPPED: 3 } as Record<string, number>;
|
||||
return e.validations
|
||||
.filter((v) => v.renderJobId === latestRun)
|
||||
.slice()
|
||||
.sort((a, b) => (order[a.status] ?? 9) - (order[b.status] ?? 9))
|
||||
.map((v) => (
|
||||
<div key={v.id} className="px-4 py-2 text-sm flex items-start gap-3">
|
||||
<span className={cn("w-16 shrink-0 text-xs font-medium", CHECK_STYLES[v.status] ?? "")}>
|
||||
{v.status}
|
||||
</span>
|
||||
<span className="w-48 shrink-0 text-zinc-300 font-mono text-xs pt-0.5">{v.checkName}</span>
|
||||
<span className="text-zinc-400 text-xs pt-0.5">
|
||||
{v.message ??
|
||||
(v.expected === v.actual ? v.actual : `expected ${v.expected ?? "—"}, got ${v.actual ?? "—"}`)}
|
||||
</span>
|
||||
</div>
|
||||
));
|
||||
})()}
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* QC history — latest decision is the authoritative one */}
|
||||
{e.qcReviews.length > 0 && (
|
||||
<div className="rounded-lg border border-zinc-800 bg-zinc-900/40">
|
||||
<div className="px-4 py-2.5 border-b border-zinc-800 text-sm font-medium text-white">QC</div>
|
||||
<div className="divide-y divide-zinc-800/60">
|
||||
{e.qcReviews.map((q) => (
|
||||
<div key={q.id} className="px-4 py-2.5 text-sm">
|
||||
<div className="flex items-center gap-3 flex-wrap">
|
||||
<span className={cn("text-xs font-medium", q.result === "PASS" ? "text-emerald-400" : "text-red-400")}>
|
||||
QC {q.result}
|
||||
</span>
|
||||
<span className="text-xs text-zinc-400">{q.reviewerName ?? "unknown reviewer"}</span>
|
||||
<span className="text-xs text-zinc-500">{q.source === "AE_PANEL" ? "AE panel" : "web"}</span>
|
||||
<span className="text-xs text-zinc-500">{new Date(q.createdAt).toLocaleString()}</span>
|
||||
</div>
|
||||
{q.notes && <div className="mt-1 text-xs text-zinc-400 whitespace-pre-wrap">{q.notes}</div>}
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Delivery membership */}
|
||||
{e.deliveryItems.length > 0 && (
|
||||
<div className="rounded-lg border border-zinc-800 bg-zinc-900/40">
|
||||
<div className="px-4 py-2.5 border-b border-zinc-800 text-sm font-medium text-white">Deliveries</div>
|
||||
<div className="divide-y divide-zinc-800/60">
|
||||
{e.deliveryItems.map((d) => (
|
||||
<div key={d.id} className="px-4 py-2.5 text-sm flex items-center gap-3 flex-wrap">
|
||||
<Link href="/pipeline/deliveries" className="text-zinc-200 hover:text-white">
|
||||
#{d.package.packageNumber} · {d.package.name}
|
||||
</Link>
|
||||
<span className="text-xs text-zinc-500">episode {d.package.episode || "—"}</span>
|
||||
<span className="text-xs text-zinc-400">{d.package.status}</span>
|
||||
<span className="text-xs text-zinc-500">
|
||||
item {d.status.toLowerCase()}
|
||||
{d.linkMode ? ` · ${d.linkMode}` : ""}
|
||||
</span>
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Render attempts */}
|
||||
<div className="rounded-lg border border-zinc-800 bg-zinc-900/40">
|
||||
<div className="px-4 py-2.5 border-b border-zinc-800 text-sm font-medium text-white">
|
||||
|
||||
Reference in New Issue
Block a user