Commit Graph

15 Commits

Author SHA1 Message Date
twotalesanimation 2b373737d8 feat(review): review players usable on phones
Deploy / deploy (push) Successful in 3m11s
Internal review: the comments panel stayed a 320px sidebar on phones,
leaving the video a 55px strip. Below md it now sits under the video
(collapsible, arrow pointing down/up), and the top bar puts shot + version
on one row with the share and approval actions on a second.

Client review: the header's three-column grid overlapped on phones
(Approve drawn over the shot code). Below md it is two rows: back, shot and
prev/next, then status and the decision buttons. The status badge now shows
on phones, and the notes toggle points down/up to match its position.

Desktop is unchanged on both.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-18 08:13:14 +02:00
twotalesanimation 28e8c47907 feat(client-portal): let a reviewer edit and delete their own notes
Notes left through a review link were write-once. A client who mistyped a
timecode or changed their mind had no way to correct it and had to add a second
note contradicting the first, which the studio then had to reconcile by hand.

PATCH and DELETE on comment/[commentId] cover both. Only the reviewer's own
notes are touchable: the studio's comments and those of every other review
session are read-only through a link, whatever the holder sends. Ownership is
re-checked server-side on every write, so the canEdit flag now returned by the
versions route only decides whether to offer the controls and grants nothing.

Refusals are 404 rather than 403 throughout, since a link holder has no business
learning which comment ids exist outside their own notes.

Only the text is editable. The frame a note is pinned to is what the studio
works from, so moving it would silently repoint feedback someone may already
have actioned; a note about a different frame is a new note. Deleting a drawing
note also removes its strokes, mirroring deleteComment in actions/comments.ts,
and the page reloads the player afterwards so the frame does not keep showing
marks that no longer exist. Delete goes through a confirmation that shows the
note and says plainly that it disappears for the studio too.

Worth knowing before this reaches a show: everyone holding the same review link
is the same author. A ReviewSession with no email resolves to a token-derived
guest user, so one link sent to three people gives all three one identity and
any of them can now edit or delete the others' notes. That model is not new,
which is why their comments already showed as one name, but edit and delete is
the first feature where it grants real power rather than muddling attribution.
Per-reviewer links with email set are the fix if that is not wanted, and that is
a change to how links are issued rather than to this code. The scope is
documented on reviewClientEmail so the next reader meets it before it surprises
them.

getOrCreateClientUser was copy-pasted into the comment and approve routes with
the fallback-email expression spelled out in three places. It is one set of
helpers in review-auth.ts now, including findReviewUser, a read-only variant so
that merely opening a review link does not conjure a User row just to answer
"is this theirs?", and ownsComment, the single rule shared by the route that
offers the controls and the route that enforces them.

Nine tests cover that rule directly: internal users' notes stay read-only, a
session that has never posted owns nothing, and an authorless comment — one
whose User was deleted, since Comment.authorId is SetNull — cannot be claimed by
anyone. The routes themselves are not covered, so exercise edit and delete
against a real review link before handing one to a client.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-31 18:17:40 +02:00
twotalesanimation 87332cdae3 Collapseable Comments section
Deploy / deploy (push) Successful in 2m46s
2026-07-16 19:17:17 +02:00
twotalesanimation 7026a5342b fixed client review player annotations
Deploy / deploy (push) Successful in 2m46s
2026-07-02 15:58:20 +02:00
twotalesanimation 13d47315dd download link updated
Deploy / deploy (push) Successful in 2m38s
2026-06-25 18:29:58 +02:00
twotalesanimation b683976cc6 High res uploads
Deploy / deploy (push) Successful in 3m16s
2026-06-25 09:56:41 +02:00
twotalesanimation 1a5a56cf4c updated client review page2
Deploy / deploy (push) Successful in 2m32s
2026-06-22 08:03:00 +02:00
twotalesanimation ab062a589a updated client review page
Deploy / deploy (push) Successful in 2m35s
2026-06-22 07:48:27 +02:00
twotalesanimation 0f403f13aa futher client page updates
Deploy / deploy (push) Failing after 45s
2026-06-19 12:19:58 +02:00
twotalesanimation 874a1a98f2 removed version numbers from client review
Deploy / deploy (push) Successful in 2m34s
2026-06-12 12:47:57 +02:00
twotalesanimation 23f0ceca3f client passwords
Deploy / deploy (push) Successful in 2m57s
2026-06-12 12:37:57 +02:00
twotalesanimation 5bfaf49fa1 mobile client player layoout updates
Deploy / deploy (push) Successful in 2m45s
2026-06-12 11:01:00 +02:00
twotalesanimation 289e0c367a mobile support for client review player
Deploy / deploy (push) Failing after 5m17s
2026-06-12 09:01:28 +02:00
twotalesanimation 7788907a4a task approval updates
Deploy / deploy (push) Successful in 2m38s
2026-06-11 15:55:57 +02:00
twotalesanimation 0fbe856dce Initial commit 2026-05-19 22:20:29 +02:00