2 Commits

Author SHA1 Message Date
twotalesanimation 2b373737d8 feat(review): review players usable on phones
Deploy / deploy (push) Successful in 3m11s
Internal review: the comments panel stayed a 320px sidebar on phones,
leaving the video a 55px strip. Below md it now sits under the video
(collapsible, arrow pointing down/up), and the top bar puts shot + version
on one row with the share and approval actions on a second.

Client review: the header's three-column grid overlapped on phones
(Approve drawn over the shot code). Below md it is two rows: back, shot and
prev/next, then status and the decision buttons. The status badge now shows
on phones, and the notes toggle points down/up to match its position.

Desktop is unchanged on both.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-18 08:13:14 +02:00
twotalesanimation 724b0cbefe fix(shot-status): Group by buttons fit on phones
The project picker (fixed 288px) and the Group by buttons shared one
unwrapping row, so on a phone the buttons ran off the right edge. Below md
the picker fills the row and Group by wraps onto its own line; from md it
is one row as before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-18 08:13:13 +02:00
3 changed files with 50 additions and 22 deletions
@@ -1132,10 +1132,12 @@ export function ShotStatusClient({
</div> </div>
{/* Project selector */} {/* Project selector */}
<div className="flex items-center gap-3"> {/* Phones: the picker fills the row and "Group by" wraps onto its own
line. From md: one row, as on desktop. */}
<div className="flex flex-wrap items-center gap-3">
<label className="text-sm text-zinc-400 shrink-0">Project:</label> <label className="text-sm text-zinc-400 shrink-0">Project:</label>
<Select value={selectedProjectId ?? ""} onValueChange={handleProjectChange}> <Select value={selectedProjectId ?? ""} onValueChange={handleProjectChange}>
<SelectTrigger className="w-72"> <SelectTrigger className="flex-1 min-w-0 md:flex-none md:w-72">
<SelectValue placeholder="Select a project..." /> <SelectValue placeholder="Select a project..." />
</SelectTrigger> </SelectTrigger>
<SelectContent> <SelectContent>
@@ -1148,7 +1150,7 @@ export function ShotStatusClient({
</SelectContent> </SelectContent>
</Select> </Select>
{selectedProject && !isEpisodic && ( {selectedProject && !isEpisodic && (
<> <div className="flex w-full md:w-auto items-center gap-3">
<span className="text-sm text-zinc-500">Group by:</span> <span className="text-sm text-zinc-500">Group by:</span>
{(["flat", "scene", "group"] as const).map((mode) => ( {(["flat", "scene", "group"] as const).map((mode) => (
<button <button
@@ -1164,7 +1166,7 @@ export function ShotStatusClient({
{mode === "flat" ? "None" : mode === "scene" ? "Scene" : "Group"} {mode === "flat" ? "None" : mode === "scene" ? "Scene" : "Group"}
</button> </button>
))} ))}
</> </div>
)} )}
</div> </div>
+19 -8
View File
@@ -28,6 +28,8 @@ import {
Clock, Clock,
ChevronLeft, ChevronLeft,
ChevronRight, ChevronRight,
ChevronDown,
ChevronUp,
Copy, Copy,
Check, Check,
Download, Download,
@@ -357,9 +359,11 @@ export default function ClientReviewPage({
return ( return (
<div className="flex flex-col h-screen bg-zinc-950 text-white overflow-hidden"> <div className="flex flex-col h-screen bg-zinc-950 text-white overflow-hidden">
{/* Header */} {/* Header */}
<header className="grid grid-cols-[1fr_auto_1fr] items-center gap-2 px-4 py-2.5 border-b border-zinc-800 bg-zinc-900 shrink-0"> {/* Phones: back + shot + prev/next on the first row, status and decision
buttons on a second full-width row. From md: the three-column grid. */}
<header className="flex flex-wrap items-center gap-2 md:grid md:grid-cols-[1fr_auto_1fr] px-4 py-2.5 border-b border-zinc-800 bg-zinc-900 shrink-0">
{/* Left: back + shot path */} {/* Left: back + shot path */}
<div className="flex items-center gap-3 min-w-0"> <div className="flex items-center gap-3 min-w-0 flex-1 md:flex-none">
<Link <Link
href={`/client/${token}`} href={`/client/${token}`}
className="text-zinc-400 hover:text-white transition-colors flex items-center gap-1.5 text-sm shrink-0" className="text-zinc-400 hover:text-white transition-colors flex items-center gap-1.5 text-sm shrink-0"
@@ -387,7 +391,7 @@ export default function ClientReviewPage({
<span className="text-xs text-zinc-500 hidden sm:block">{project?.code}</span> <span className="text-xs text-zinc-500 hidden sm:block">{project?.code}</span>
<span className="text-zinc-600">/</span> <span className="text-zinc-600">/</span>
{contextCode && ( {contextCode && (
<span className="font-mono font-semibold">{contextCode}</span> <span className="font-mono font-semibold truncate">{contextCode}</span>
)} )}
{taskName && ( {taskName && (
<> <>
@@ -417,11 +421,11 @@ export default function ClientReviewPage({
</div> </div>
</div> </div>
{/* Center: status badge + decision buttons */} {/* Center: status badge + decision buttons (their own row on phones) */}
<div className="flex items-center gap-2 shrink-0"> <div className="order-last md:order-none flex w-full md:w-auto items-center gap-2 shrink-0">
<span <span
className={cn( className={cn(
"text-xs px-2.5 py-1 rounded-full border hidden sm:inline-flex items-center gap-1 shrink-0", "text-xs px-2.5 py-1 rounded-full border inline-flex items-center gap-1 shrink-0 mr-auto md:mr-0",
approvalStyle approvalStyle
)} )}
> >
@@ -542,10 +546,17 @@ export default function ClientReviewPage({
className="flex items-center justify-center h-10 w-full border-b border-zinc-800 hover:bg-zinc-800/60 transition-colors shrink-0" className="flex items-center justify-center h-10 w-full border-b border-zinc-800 hover:bg-zinc-800/60 transition-colors shrink-0"
title={commentsOpen ? "Collapse notes" : "Expand notes"} title={commentsOpen ? "Collapse notes" : "Expand notes"}
> >
{/* Below the video on phones, so down/up there and right/left from md. */}
{commentsOpen ? ( {commentsOpen ? (
<ChevronRight className="h-4 w-4 text-zinc-400" /> <>
<ChevronDown className="h-4 w-4 text-zinc-400 md:hidden" />
<ChevronRight className="h-4 w-4 text-zinc-400 hidden md:block" />
</>
) : ( ) : (
<ChevronLeft className="h-4 w-4 text-zinc-400" /> <>
<ChevronUp className="h-4 w-4 text-zinc-400 md:hidden" />
<ChevronLeft className="h-4 w-4 text-zinc-400 hidden md:block" />
</>
)} )}
{!commentsOpen && ( {!commentsOpen && (
<MessageSquare className="h-4 w-4 text-zinc-400 mt-1" /> <MessageSquare className="h-4 w-4 text-zinc-400 mt-1" />
+25 -10
View File
@@ -33,6 +33,7 @@ import {
XCircle, XCircle,
AlertCircle, AlertCircle,
ChevronDown, ChevronDown,
ChevronUp,
ChevronRight, ChevronRight,
ChevronLeft, ChevronLeft,
ArrowLeft, ArrowLeft,
@@ -231,8 +232,9 @@ export function ReviewPageClient({
return ( return (
<div className="flex flex-col h-screen bg-background overflow-hidden"> <div className="flex flex-col h-screen bg-background overflow-hidden">
{/* Top bar */} {/* Top bar — phones: shot + version on the first row, actions wrap to a
<div className="flex items-center gap-3 px-4 py-2 border-b border-border bg-card shrink-0"> second row. From md: one row. */}
<div className="flex flex-wrap md:flex-nowrap items-center gap-x-3 gap-y-2 px-4 py-2 border-b border-border bg-card shrink-0">
<Link <Link
href={backHref} href={backHref}
className="text-muted-foreground hover:text-foreground transition-colors" className="text-muted-foreground hover:text-foreground transition-colors"
@@ -247,7 +249,7 @@ export function ReviewPageClient({
<span className="text-muted-foreground">/</span> <span className="text-muted-foreground">/</span>
{contextCode && ( {contextCode && (
<> <>
<span className="font-mono text-sm font-semibold">{contextCode}</span> <span className="font-mono text-sm font-semibold truncate">{contextCode}</span>
<span className="text-muted-foreground">/</span> <span className="text-muted-foreground">/</span>
</> </>
)} )}
@@ -284,6 +286,10 @@ export function ReviewPageClient({
{version.approvalStatus.replace("_", " ")} {version.approvalStatus.replace("_", " ")}
</span> </span>
{/* Actions: their own full-width row on phones; md:contents puts them
back in the top bar's single row, exactly as before. */}
{(canShare || canApprove) && (
<div className="flex w-full items-center justify-end gap-3 md:contents">
{/* Share with Client */} {/* Share with Client */}
{canShare && ( {canShare && (
<ShareWithClientButton <ShareWithClientButton
@@ -330,9 +336,11 @@ export function ReviewPageClient({
</div> </div>
)} )}
</div> </div>
)}
</div>
{/* Main content — player + comments */} {/* Main content — player + comments: stacked on phones, side by side from md */}
<div className="flex flex-1 overflow-hidden"> <div className="flex flex-col md:flex-row flex-1 overflow-hidden">
{/* Player — 70% */} {/* Player — 70% */}
<div className="flex-1 min-w-0 min-h-0 overflow-hidden flex flex-col bg-black"> <div className="flex-1 min-w-0 min-h-0 overflow-hidden flex flex-col bg-black">
<ReviewPlayer <ReviewPlayer
@@ -350,20 +358,27 @@ export function ReviewPageClient({
{/* Comment panel — collapsible */} {/* Comment panel — collapsible */}
<div <div
className={cn( className={cn(
"shrink-0 flex flex-col border-l border-border transition-all duration-200", "shrink-0 flex flex-col border-t md:border-t-0 md:border-l border-border transition-all duration-200",
commentsOpen ? "w-80 xl:w-96" : "w-10" commentsOpen ? "h-[45%] md:h-auto md:w-80 xl:w-96" : "h-10 md:h-auto md:w-10"
)} )}
> >
{/* Collapse toggle */} {/* Collapse toggle — the panel sits below the video on phones, so
the arrow points down/up there and right/left from md. */}
<button <button
onClick={() => setCommentsOpen((o) => !o)} onClick={() => setCommentsOpen((o) => !o)}
className="flex items-center justify-center h-10 w-full border-b border-border hover:bg-muted/50 transition-colors shrink-0" className="flex items-center justify-center h-10 w-full border-b border-border hover:bg-muted/50 transition-colors shrink-0"
title={commentsOpen ? "Collapse comments" : "Expand comments"} title={commentsOpen ? "Collapse comments" : "Expand comments"}
> >
{commentsOpen ? ( {commentsOpen ? (
<ChevronRight className="h-4 w-4 text-muted-foreground" /> <>
<ChevronDown className="h-4 w-4 text-muted-foreground md:hidden" />
<ChevronRight className="h-4 w-4 text-muted-foreground hidden md:block" />
</>
) : ( ) : (
<ChevronLeft className="h-4 w-4 text-muted-foreground" /> <>
<ChevronUp className="h-4 w-4 text-muted-foreground md:hidden" />
<ChevronLeft className="h-4 w-4 text-muted-foreground hidden md:block" />
</>
)} )}
{!commentsOpen && ( {!commentsOpen && (
<MessageSquare className="h-4 w-4 text-muted-foreground mt-1" /> <MessageSquare className="h-4 w-4 text-muted-foreground mt-1" />