twotalesanimation
caaa333f02
Deploy / deploy (push) Failing after 19m11s
Two independent features landing together: Generated shot thumbnails — a shot can now carry a thumbnail promoted from a render export (Shot.generatedThumbnailUrl/generatedThumbnailFrom) alongside the existing brief-supplied thumbnailUrl, which always takes display precedence (lib/shot-thumbnail.ts) so a promoted frame can only ever fill a gap, never overwrite the brief. Shows with pipelineConfig.autoShotThumbnail promote automatically on every finished export (lib/render-pipeline/preview.ts); promoteExportThumbnail/ clearGeneratedThumbnail (actions/shots.ts) are the manual equivalent for everyone else. Worker-side seek logic for picking the promoted frame is covered by RenderWorker/VFXReviewWorker.Tests/ThumbnailSeekTests.cs. Bulk shot delete — the shot-status page's selection bar gets a "Bulk Actions" dropdown (alongside the existing Change Due Date) with Delete Shots. bulkDeleteShots() (actions/shots.ts) deletes one at a time rather than in a single statement: exports_shotId_fkey is ON DELETE RESTRICT by design, so a shot with renders or deliveries on record is protected and gets skipped and reported by name rather than aborting the whole selection or being silently destroyed along with its history. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
41 lines
1.7 KiB
TypeScript
41 lines
1.7 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { shotThumbnail, isGeneratedThumbnail } from "./shot-thumbnail";
|
|
|
|
/**
|
|
* The whole point of the second column is that promotion can never destroy the
|
|
* reference frame that came with the brief. These cases are that guarantee.
|
|
*/
|
|
describe("shotThumbnail", () => {
|
|
it("prefers the reference frame over a render-derived one", () => {
|
|
expect(
|
|
shotThumbnail({ thumbnailUrl: "/api/files/image/ref.jpg", generatedThumbnailUrl: "/api/files/image/gen.jpg" })
|
|
).toBe("/api/files/image/ref.jpg");
|
|
});
|
|
|
|
it("falls back to the render frame when the show supplied no still", () => {
|
|
expect(shotThumbnail({ thumbnailUrl: null, generatedThumbnailUrl: "/api/files/image/gen.jpg" })).toBe(
|
|
"/api/files/image/gen.jpg"
|
|
);
|
|
});
|
|
|
|
it("returns null when the shot has neither", () => {
|
|
expect(shotThumbnail({ thumbnailUrl: null, generatedThumbnailUrl: null })).toBeNull();
|
|
expect(shotThumbnail(null)).toBeNull();
|
|
expect(shotThumbnail({})).toBeNull();
|
|
});
|
|
|
|
it("treats an empty string as no thumbnail", () => {
|
|
// updateShot accepts "" from a cleared form field, which must not win over
|
|
// a generated frame or render as a broken <img src="">.
|
|
expect(shotThumbnail({ thumbnailUrl: "", generatedThumbnailUrl: "/api/files/image/gen.jpg" })).toBe(
|
|
"/api/files/image/gen.jpg"
|
|
);
|
|
});
|
|
|
|
it("reports whether what is displayed came from a render", () => {
|
|
expect(isGeneratedThumbnail({ thumbnailUrl: null, generatedThumbnailUrl: "/g.jpg" })).toBe(true);
|
|
expect(isGeneratedThumbnail({ thumbnailUrl: "/r.jpg", generatedThumbnailUrl: "/g.jpg" })).toBe(false);
|
|
expect(isGeneratedThumbnail({ thumbnailUrl: null, generatedThumbnailUrl: null })).toBe(false);
|
|
});
|
|
});
|