fix(validation): separate output file numbering from comp frame numbers
Deploy / deploy (push) Successful in 6m13s
Deploy / deploy (push) Successful in 6m13s
A render carries frame numbers in two unrelated systems. The comp is anchored to its plate's timecode, so its timeline runs 1247792-1247896; the output module names files from 1001. Validation compared the file numbers against the comp range and failed every correctly-rendered shot by ~1.2 million frames — first_frame, last_frame and missing_frames all reporting a defect that was not there. The manifest now carries outputFrameStart (the output module's starting number, house convention 1001) alongside the comp range. Count and contiguity are measured on the output numbering; first/last compare against outputFrameStart and are SKIPPED on older manifests, where the count and gap checks still hold on their own. The same conflation broke the API timecode fallback: it anchored on the comp's frameStart while the render's first frame is 1001, producing a +1246791 frame "offset". Shot.timecodeStart is the edit in-point and the plate carries handleFrames of head handle, so the reference is the API value less handles, anchored on the render's own first frame. Verified on the shot that reported it: UNG_107_051_010 v004 now passes count, contiguity and a plate-anchored timecode match. Regression tests cover both coordinate systems, including that a genuine +8 handle offset still fails. Panel 2.1.2. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
+16
-2
@@ -18,7 +18,12 @@ var CONFIG = {
|
||||
// Format: "//SAN/=V:/_EXPORTS/" — several separated by ";".
|
||||
// Usually unnecessary: see resolveServerPath, which derives the local path
|
||||
// from Export Root when the layouts mirror each other.
|
||||
pathMappings: ""
|
||||
pathMappings: "",
|
||||
// The number the first frame of every rendered sequence carries, set by the
|
||||
// output module template. House convention is 1001, and it is deliberately
|
||||
// independent of the comp's start frame — comps are anchored to the plate's
|
||||
// timecode, so their frame numbers run into the millions.
|
||||
sequenceStart: 1001
|
||||
};
|
||||
|
||||
var SETTINGS_GROUP = "VFXReviewConnector";
|
||||
@@ -27,7 +32,7 @@ var SETTINGS_KEY = "cfg";
|
||||
// Bump on every change deployed to a workstation. The panel reports this to
|
||||
// the server on load, so Pipeline → Machines shows which version each machine
|
||||
// is actually running and flags the ones left behind.
|
||||
var PANEL_VERSION = "2.1.1";
|
||||
var PANEL_VERSION = "2.1.2";
|
||||
|
||||
(function VFXReviewConnector(thisObj) {
|
||||
var uiState = {
|
||||
@@ -3077,6 +3082,11 @@ var PANEL_VERSION = "2.1.1";
|
||||
var fBanner = addField(dlg, "Banner Path:", CONFIG.bannerImagePath);
|
||||
var fEmail = addField(dlg, "Artist Email:", CONFIG.artistEmail);
|
||||
var fHandles= addField(dlg, "Handle Frames:", String(CONFIG.handleFrames));
|
||||
var fSeqStart = addField(dlg, "Sequence Start:", String(CONFIG.sequenceStart));
|
||||
fSeqStart.helpTip =
|
||||
"The frame number the first file of every rendered sequence carries,\n" +
|
||||
"set by the output module template (house convention: 1001).\n" +
|
||||
"Not the comp's start frame — comps are anchored to the plate's timecode.";
|
||||
var fMappings = addField(dlg, "Path Mappings:", CONFIG.pathMappings);
|
||||
fMappings.helpTip =
|
||||
"Optional. Rewrites paths the server supplies (render folders are\n" +
|
||||
@@ -3104,6 +3114,7 @@ var PANEL_VERSION = "2.1.1";
|
||||
CONFIG.artistEmail = trimText(fEmail.text);
|
||||
CONFIG.handleFrames = parseInt(fHandles.text, 10) || 8;
|
||||
CONFIG.pathMappings = trimText(fMappings.text);
|
||||
CONFIG.sequenceStart = parseInt(fSeqStart.text, 10) || 1001;
|
||||
saveConfig();
|
||||
populateProjectDropdown();
|
||||
}
|
||||
@@ -3730,6 +3741,9 @@ var PANEL_VERSION = "2.1.1";
|
||||
outputModuleTemplate: "EXR Sequence",
|
||||
frameStart: frameStart,
|
||||
frameEnd: frameEnd,
|
||||
// What the rendered files are actually named, which the comp's frame
|
||||
// range is not: the comp is anchored to the plate's timecode.
|
||||
outputFrameStart: parseInt(CONFIG.sequenceStart, 10) || 1001,
|
||||
fps: Math.round(comp.frameRate * 1000) / 1000,
|
||||
width: comp.width,
|
||||
height: comp.height,
|
||||
|
||||
Reference in New Issue
Block a user