fix(connector): build shots at the shot's frame rate, not a hardcoded 24
Deploy / deploy (push) Successful in 6m23s
Deploy / deploy (push) Successful in 6m23s
Shot.fps existed, the lookup API returned it, and one button honoured it — Set Start Timecode — while the shot builder ignored it entirely. Comps were created at 24 and every plate conformed to 24. DH2 is a 25 fps show. Its plates carry framesPerSecond 25/1, so comps built at 24 conform every plate to the wrong speed and compute every frame-from-timecode sum against the wrong rate. The builder now takes the rate from the shot record, which is the show's delivery rate and therefore the authority; a plate's own rate is whatever happens to be on disk. Import Renders follows the comp it imports into, and Import EXR follows the shot. Validation gains plate_fps, comparing the render against the timing plate. timecode_fps only compares the render to its manifest and both come from the comp, so a shot built at the wrong rate agrees with itself and passes; the plate is the independent witness. It is a WARN, never a FAIL: sampling DH2 found one plate at 50 fps against a 25 fps show, a deliberate over-crank, so a whole-number multiple is reported as exactly that and anything else as a probable rate mistake. Note this does not fix the data: all 175 DH2 shots still carry fps 24 from the create-time default and need correcting before their comps are rebuilt. Panel 2.4.0, worker 1.4.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -103,6 +103,21 @@ Source EXR plates are read from **`<Footage Root>/{SHOW_ID}/`**. Configure `foot
|
||||
└── {EPISODE_CODE}_*.mov # matched by episode prefix
|
||||
```
|
||||
|
||||
### Frame rate
|
||||
|
||||
Comps are built at the **shot record's `fps`**, and plates are conformed to it.
|
||||
That value is the show's delivery rate and the authority; a plate's own rate is
|
||||
whatever happens to be on disk.
|
||||
|
||||
`fps` defaults to 24 when a shot is created, so **check it after importing a
|
||||
show that is not 24** — every shot carries its own value, and a wrong one
|
||||
produces comps at the wrong rate, plates conformed to the wrong speed, and
|
||||
timecode-to-frame sums that are quietly off.
|
||||
|
||||
A plate at a whole-number multiple of the show rate (50 fps on a 25 fps show) is
|
||||
a deliberate over-crank and is conformed as intended. Validation reports the
|
||||
difference either way, saying which of the two it looks like.
|
||||
|
||||
**Scenes are not folders.** Standard projects have no level between the show
|
||||
folder and the shot folder — the scene picker filters the shot list only.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user